Comment 10 for bug 1296414

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/90280
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=29f2953edf2dc95569d53433d7c28251f652f8d4
Submitter: Jenkins
Branch: master

commit 29f2953edf2dc95569d53433d7c28251f652f8d4
Author: jichenjc <email address hidden>
Date: Wed Apr 23 06:17:02 2014 +0800

    Remove comments and to-do for quota inconsistency

    There are comments for quota inconsistency in function
    _complete_deletion and considering race conditions.

    _complete_deletion was called by _complete_partial_deletion
    and_delete_instance only if the instance state is DELETED
    compute can enter _complete_partial_deletion
    while if _complete_deletion called in _delete_instance,
    that means instance vm state already become DELETED

    also, if the _delete_instance was called with instance
    state SOFT_DELETED, the quotas.rollback() will be called
    it will make quotas.commit later take no effect
    since the quotas.reservations is already None

    so there is no race conditions and the comments can be removed

    Change-Id: Iddb9e5197ca7ca9bd4692d63bb5c7f9a2ab44be5
    Partial-Bug: #1296414