Comment 2 for bug 1285886

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/77046
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=621fc02f70fa4fa50b2f05167eefa39b71f72024
Submitter: Jenkins
Branch: master

commit 621fc02f70fa4fa50b2f05167eefa39b71f72024
Author: Aaron Rosen <email address hidden>
Date: Thu Feb 27 18:44:52 2014 -0800

    Nova should pass device_id='' instead of None to neutron.update_port()

    In the case that neutron raises an error and nova needs to undo the api
    calls it's done against neutron it should pass device_id='' instead of
    None otherwise neutron raises an exception.

    Note: This should have a unit test but it's near impossible
    to add one right without duplicating all of _stub_allocate_for_instance
    due to the fact that it's using some crazy logic in the tests to make
    decisions based on an index that's passed it. X.x

    Change-Id: I91334c07401ff379f71fdef1d5bd080cc68a72ab
    Closes-bug: #1285886