commit ea7da5152cdca7ba674e2137c3899909995e2287
Author: Solly Ross <email address hidden>
Date: Tue Feb 4 14:27:51 2014 -0500
Change listen address on libvirt live-migration
Previously, in order for libvirt live migration to work,
the graphics listen addresses (VNC and/or Spice) had to be
set on both machines to be 0.0.0.0 or ::. This was because libvirt
would try to rebind to the source address on the destination
machine, but would fail due to the source machine already having
that address (this would not happen for 0.0.0.0 or ::, however).
Now, a modified copy of the instance's XML is passed to libvirt's
migrate function, such that the listen addresses are that of the
destination machine. The addresses are stashed in the pre-migration
data by the destination pre-migration method.
Note that this functionality will only work on versions of libvirt
with the VIR_DOMAIN_XML_MIGRATABLE flag. If the flag is not detected
(anything vanilla libvirt less than 1.0.0), the live migration code
will fall back to the old method.
Reviewed: https:/ /review. openstack. org/73428 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=ea7da5152cd ca7ba674e2137c3 899909995e2287
Committed: https:/
Submitter: Jenkins
Branch: master
commit ea7da5152cdca7b a674e2137c38999 09995e2287
Author: Solly Ross <email address hidden>
Date: Tue Feb 4 14:27:51 2014 -0500
Change listen address on libvirt live-migration
Previously, in order for libvirt live migration to work,
the graphics listen addresses (VNC and/or Spice) had to be
set on both machines to be 0.0.0.0 or ::. This was because libvirt
would try to rebind to the source address on the destination
machine, but would fail due to the source machine already having
that address (this would not happen for 0.0.0.0 or ::, however).
Now, a modified copy of the instance's XML is passed to libvirt's
migrate function, such that the listen addresses are that of the
destination machine. The addresses are stashed in the pre-migration
data by the destination pre-migration method.
Note that this functionality will only work on versions of libvirt XML_MIGRATABLE flag. If the flag is not detected
with the VIR_DOMAIN_
(anything vanilla libvirt less than 1.0.0), the live migration code
will fall back to the old method.
Fixes: bug #1279563
Change-Id: I6c950028302719 3179c11d18ad424 2e165a9ad6e