Comment 4 for bug 1279317

Reviewed: https://review.openstack.org/80247
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6def27b434a53aa8c1aca62640a6c072cc21209e
Submitter: Jenkins
Branch: master

commit 6def27b434a53aa8c1aca62640a6c072cc21209e
Author: John Garbutt <email address hidden>
Date: Thu Mar 13 10:58:58 2014 +0000

    xenapi: fixup agent tests

    The root cause of the slow agent tests was not mocking this method:
    compute_utils.add_instance_fault_from_exc

    This cleans up the tests to share a bit more code, and ensures they
    actually check that the appropriate exception is raised.

    This change adds a log message to report errors that could occur in
    running systems that also helped identify this issue in the unit tests.

    test_spawn_fails_agent_not_implemented was a duplicate test and has been
    removed.

    Change-Id: I6fd31520fffd5e888ce0c2b58af2715f0d929ce1
    Closes-Bug: #1279317