set_host_enabled, which is being called by nova host-update is needed to be implemented when the driver need to perform operations on enable/disable request, while service_update just disables the compute service.
set_host_enabled wasn't implement in the libvirt driver and was introduced to solve the auto disable/re-enable issue.
However, it should have been private.
I think you are right and we do need to discuss
1) nova service-update
2) nova host-update
and make nova host-update to set a reason.
However, at the moment, the auto disable (set_host_enabled) method should be private.
Jay,
set_host_enabled, which is being called by nova host-update is needed to be implemented when the driver need to perform operations on enable/disable request, while service_update just disables the compute service.
set_host_enabled wasn't implement in the libvirt driver and was introduced to solve the auto disable/re-enable issue.
However, it should have been private.
I think you are right and we do need to discuss
1) nova service-update
2) nova host-update
and make nova host-update to set a reason.
However, at the moment, the auto disable (set_host_enabled) method should be private.