Comment 10 for bug 1251803

Revision history for this message
Vladik Romanovsky (vladik-romanovsky) wrote :

Jay,

Well, Xen driver is implemented in nova/virt/xenapi/driver.py
The proposed patch is not affecting xenserver in anyway.
It is only fixing the method that is currently in libvirt, which shouldn't be public.

Before the following patch libvirt driver didn't have an implementation for set_host_enabled and the only way to disable the service was done using nova service-update not nova host-update, which would result in an error:
https://review.openstack.org/#/c/52189/

If your concern is that the libvirt driver wont have set_host_enabled method, we can add it in another patch, but i'm not sure if it's needed because there are no driver specific operations that should be done in order to disable a service.

Vladik