Ok so this looks much better now. Launchpad is horrible for commenting on patches, but several issues with ephemerals that I can see:
+ fs_label='ephemeral0',
This should be cache_name since there can be more than one ephemeral disk
+ ephemeral_size=instance['ephemeral_gb'])
This is not always true - we are able to specify the size of ephemerals too through block device mapping. This is tricky since we don't have that info in the xml. I am not sure how to handle this - I need to look into this a bit more.
Ok so this looks much better now. Launchpad is horrible for commenting on patches, but several issues with ephemerals that I can see: 'ephemeral0' , size=instance[ 'ephemeral_ gb'])
+ fs_label=
This should be cache_name since there can be more than one ephemeral disk
+ ephemeral_
This is not always true - we are able to specify the size of ephemerals too through block device mapping. This is tricky since we don't have that info in the xml. I am not sure how to handle this - I need to look into this a bit more.