commit cbeb5e51886b0296349fc476305bfe3d63c627c3
Author: Nikola Dipanov <email address hidden>
Date: Tue Dec 10 17:43:17 2013 +0100
libvirt: Fix root disk leak in live mig
This patch makes sure that _create_images_and_backing method of the
libvirt driver (called in several places, but most problematic one is
the call in the pre_live_migration method) creates all the files the
instance needs that are not present.
Prioir to this patch - the method would only attempt to download the
image, and if it did so with the path of the ephemeral drives, it could
expose the image to other users as an ephemeral devices. See the related
bug for more detaiis.
After this patch - we properly distinguish between image, ephemeral and
swap files, and make sure that the imagebackend does the correct thing.
This patch also includes part of commit
65386c91910ee03d947c2b8bcc226a53c30e060a, not cherry-picked as a whole
due to the fact that it is a trivial change, and to avoud the
proliferation of patches needed to fix this bug.
(cherry picked from commit c69a619668b5f44e94a8fe1a23f3d887ba2834d7)
Reviewed: https:/ /review. openstack. org/68660 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=cbeb5e51886 b0296349fc47630 5bfe3d63c627c3
Committed: https:/
Submitter: Jenkins
Branch: stable/grizzly
commit cbeb5e51886b029 6349fc476305bfe 3d63c627c3
Author: Nikola Dipanov <email address hidden>
Date: Tue Dec 10 17:43:17 2013 +0100
libvirt: Fix root disk leak in live mig
This patch makes sure that _create_ images_ and_backing method of the
libvirt driver (called in several places, but most problematic one is
the call in the pre_live_migration method) creates all the files the
instance needs that are not present.
Prioir to this patch - the method would only attempt to download the
image, and if it did so with the path of the ephemeral drives, it could
expose the image to other users as an ephemeral devices. See the related
bug for more detaiis.
After this patch - we properly distinguish between image, ephemeral and
swap files, and make sure that the imagebackend does the correct thing.
Closes-bug: #1251590
Co-authored-by: Loganathan Parthipan <email address hidden>
This patch also includes part of commit ee03d947c2b8bcc 226a53c30e060a, not cherry-picked as a whole
65386c91910
due to the fact that it is a trivial change, and to avoud the
proliferation of patches needed to fix this bug.
(cherry picked from commit c69a619668b5f44 e94a8fe1a23f3d8 87ba2834d7)
Conflicts: tests/test_ libvirt. py virt/libvirt/ driver. py
nova/
nova/
Change-Id: I78aa2f4243899d b4f4941e77014a7 e18e27fc63e