@Dan: My reading of the code is that at the moment the disable reason will be set to: "Connection to libvirt lost: %s"
My reason for saying this needs to be reverted in the short term is that as it stands it brakes a production system in a potentially dangerous way by re-enabling hosts that are meant to be kept disabled. If there is a quick fix, i.e. if adding logic on the contents of the reason string is going to be acceptable to yourself and Dan Smith then I can see that could be done as rapid fix.
However if we have to go down the route of adding additional state to the ServiceGroup API, which will mean a DB migration, then I don't think the change can stay in the system until that works its way through the review process.
Change reference should be: https:/ /review. openstack. org/#/c/ 52189/
@Dan: My reading of the code is that at the moment the disable reason will be set to: "Connection to libvirt lost: %s"
My reason for saying this needs to be reverted in the short term is that as it stands it brakes a production system in a potentially dangerous way by re-enabling hosts that are meant to be kept disabled. If there is a quick fix, i.e. if adding logic on the contents of the reason string is going to be acceptable to yourself and Dan Smith then I can see that could be done as rapid fix.
However if we have to go down the route of adding additional state to the ServiceGroup API, which will mean a DB migration, then I don't think the change can stay in the system until that works its way through the review process.