Comment 1 for bug 1250049

Revision history for this message
Daniel Berrange (berrange) wrote :

Looking at the change it current just passes "" as the disable reason string when connection to libvirtd is lost.

It seems that we could just enhance the code to pass a pre-determined string "Libvirtd offline" and then when connection to libivrtd is re-established, we can check for that disable reason, to see if we should automatically re-enable it or not.

If we wanted to avoid the string reason comparison, then adding eithe boolean flag to to track automatic vs manual disablement could be an option.

I think this could be done as a followup patch - don't see a compelling reason to revert the existing patch