OpenStack Compute (nova)

  1. Bug #1241350
  2. Comment #8

Comment 8 for bug 1241350

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/56746
Committed: http://github.com/openstack/nova/commit/e69310b27bf1c89ac9b971720b62f1cc8268de3c
Submitter: Jenkins
Branch: stable/havana

commit e69310b27bf1c89ac9b971720b62f1cc8268de3c
Author: Jay Lau <email address hidden>
Date: Fri Oct 18 22:38:13 2013 +0800

    VMware: Detach volume should not delete vmdk

    During volume detach a delete_virtual_disk_spec is used to remove
    the device from the running instance. This spec also "destroy" the
    underlying vmdk file, this is not right, we should not delete vmdk
    file when detach it from a VM instance.

    The fix was remove the fileOperation field when detach vmdk volume
    so as to make sure the volume will not be destroyed; but for iscsi
    we still need to destroy the volume.

    Also I changed the function name from delete_virtual_disk_spec to
    detach_virtual_disk_spec which is more accurate.

    Change-Id: Ibd218d6a8cfeede4f5ca74f28bc0c3d0c185bb14
    Closes-Bug: #1241350
    (cherry picked from commit 0405d7b937fdeece46efc1ba90171163f3286a56)