I agree with your first point and will fix it in the next patch.
It's easy enough to add disks.info.instance_name or disks.info.instance_uuid, but I think it's premature to add it now, since we don't support multiple images per instance yet. And we definitely didn't support them in grizzly or havana, to which this security fix needs to be backported. I'd rather keep it simpler for now, but I'll be happy to add the multiple image support to disks.info later, after that blueprint goes in.
I agree that get_set_driver_format is an ugly name, but could not think of a better one. Do you have a suggestion? I thought of just calling it get_driver_format, but didn't because I wanted to make the side effect clear, as well as the reason to call it rather than just looking at self.driver_format.
Thanks for the review Nikola.
I agree with your first point and will fix it in the next patch.
It's easy enough to add disks.info. instance_ name or disks.info. instance_ uuid, but I think it's premature to add it now, since we don't support multiple images per instance yet. And we definitely didn't support them in grizzly or havana, to which this security fix needs to be backported. I'd rather keep it simpler for now, but I'll be happy to add the multiple image support to disks.info later, after that blueprint goes in.
I agree that get_set_ driver_ format is an ugly name, but could not think of a better one. Do you have a suggestion? I thought of just calling it get_driver_format, but didn't because I wanted to make the side effect clear, as well as the reason to call it rather than just looking at self.driver_format.