Comment 16 for bug 1221190
Revision history for this message
| Daniel Berrange (berrange) wrote Re: Image format not enforced when using rescue | #16 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Looks like the flaw was introduced in this patch - it causes the libvirt imagebackend.py code to run qemu-img info to probe the disk format which is unsafe :-(
commit 494a3cb5749d52a
Author: Vishvananda Ishaya <email address hidden>
Date: Mon Apr 1 14:19:49 2013 -0700
libvirt: Get driver type from base image type.
If we are using the raw backend (no cow), we should set the driver
type based on the type of the source image instead of always
using raw.
Calls to to_xml were moved after _create_image so that the image
type could be determined when creating the xml for libvirt.
Fixes bug 1163009
Change-Id: Ic8d5f0ab83d868