Comment 5 for bug 1209421

Revision history for this message
Boden R (boden) wrote :

test_virt_drivers actually appears to provide some coverage which I don't see elsewhere, namely in testing the base (common) implemented methods of the ComputeDriver in addition to the FakeDriver.

As noted in a previous comment there is obviously some amount of overlap between what's covered in the test_virt_drivers and in the main libvirt driver tests. However there does appear to be some amount of additional coverage in test_virt_drivers from a libvirt perspective and therefore I don't think we should remove it in it's entirety without the due diligence to ensure all coverage is provided in the main libvirt tests.

That said my plan is to submit a small patch which updates the test_virt_drivers comments to reflect its not used to build the hyper matrix and also a very minor logging change to better reflect the unimplemented class / method / test. Assuming that patch goes through I'll be closing this one out. If we believe the hyper matrix should be generated via tempest or other testing magic I suggest we queue that up as a blueprint for the respective team - tho do date I haven't seen a strong need / desire for such.