Sorry that my last comment is a bit wrong. Let me correct.
I was confused with add_security_group_instance and create_server.
The proposed fix looks insufficient with nova-network security group.
In Havana, the current behavior of Nova and Neutron are as follows:
(a1) nova-network security group (with nova driver) accepts "Name" of security groups.
(a2) Nova security group with neutron driver accepts UUID or Name.
(b) Neutron native security group API requires UUID.
In Grizzy, we need to consider cases (a1) and (a2).
(b2) does not need to be considered since Neutron native security group support is not implemented in Grizzly.
Sorry that my last comment is a bit wrong. Let me correct. group_instance and create_server.
I was confused with add_security_
The proposed fix looks insufficient with nova-network security group.
In Havana, the current behavior of Nova and Neutron are as follows:
(a1) nova-network security group (with nova driver) accepts "Name" of security groups.
(a2) Nova security group with neutron driver accepts UUID or Name.
(b) Neutron native security group API requires UUID.
In Grizzy, we need to consider cases (a1) and (a2).
(b2) does not need to be considered since Neutron native security group support is not implemented in Grizzly.