commit a7f72a59ba3214f19c7bd66a7ef465ecc22794dd
Author: Daniel P. Berrange <email address hidden>
Date: Tue Feb 19 19:39:55 2013 +0000
Fix XMLMatcher error reporting
The nova.tests.matchers.XMLMismatch class implements the
get_details() method returning a dictionary with the expect
and actual XML output. It is returning a string values, but
the testtools code requires that the dictionary values are
instances of the testtools.content.Content object.
To quote the 'get_details' docs on testtools.matchers.Mismatch
:return: a dict mapping names to Content objects. name is a string to
name the detail, and the Content object is the detail to add
to the result. For more information see the API to which items from
this dict are passed testtools.TestCase.addDetail.
Related bug #1130146
Change-Id: I75ec07d8b34b04c7b8009229fda49b344ed13bec
Signed-off-by: Daniel P. Berrange <email address hidden>
Reviewed: https:/ /review. openstack. org/22350 github. com/openstack/ nova/commit/ a7f72a59ba3214f 19c7bd66a7ef465 ecc22794dd
Committed: http://
Submitter: Jenkins
Branch: master
commit a7f72a59ba3214f 19c7bd66a7ef465 ecc22794dd
Author: Daniel P. Berrange <email address hidden>
Date: Tue Feb 19 19:39:55 2013 +0000
Fix XMLMatcher error reporting
The nova.tests. matchers. XMLMismatch class implements the content. Content object.
get_details() method returning a dictionary with the expect
and actual XML output. It is returning a string values, but
the testtools code requires that the dictionary values are
instances of the testtools.
To quote the 'get_details' docs on testtools. matchers. Mismatch
:return: a dict mapping names to Content objects. name is a string to TestCase. addDetail.
name the detail, and the Content object is the detail to add
to the result. For more information see the API to which items from
this dict are passed testtools.
Related bug #1130146 c7b8009229fda49 b344ed13bec
Change-Id: I75ec07d8b34b04
Signed-off-by: Daniel P. Berrange <email address hidden>