Comment 10 for bug 1105488

Reviewed: https://review.openstack.org/447150
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1b987be2b55558dcc276fcfc8af6e39f8b6bac16
Submitter: Jenkins
Branch: master

commit 1b987be2b55558dcc276fcfc8af6e39f8b6bac16
Author: Kevin Benton <email address hidden>
Date: Fri Mar 17 14:56:36 2017 -0700

    Use vif_type='tap' for LinuxBridge for consistency

    This adjusts the Linux Bridge mechanism driver to return
    the 'tap' VIF type to Nova so the Linux Bridge agent is
    responsible for plugging all ports into bridges.

    This completely eliminates all of the work Nova was doing with
    regard to bridges so we now have one consistent path how ports
    (both compute and dhcp/l3) are connected into Linux Bridge
    networks. Both Nova and the DHCP/L3 agents will now just create
    a device and leave wiring to bridges to be completely the
    responsibility of the L2 agent.

    In order to preserve backwards compatibiliy with Ocata agents
    that won't touch compute ports, we only report back vif_type='tap'
    if the agent has a report_state value showing that it wires compute
    ports.

    This will also solve a longstanding bug (bug #1105488) that
    is preventing Nova instances from using custom bridge mappings
    since the agent will be guaranteed to be responsible for the
    connection to the bridge.

    Depends-On: I075595158d8f3b5a6811c4794aa7b91912940db5

    Related-Bug: #1617447
    Closes-Bug: #1673910
    Closes-Bug: #1105488
    Change-Id: I23c5faaeab69aede1fd038a36f4a0b8f928498ce