confirm_resize mgr call requires admin context

Bug #1071600 reported by Chris Behrens on 2012-10-26
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Chris Behrens
Folsom
Medium
Vish Ishaya
nova (Ubuntu)
Undecided
Unassigned
Quantal
Undecided
Unassigned

Bug Description

confirm_resize compute manager call should not require admin context.

From _delete() in compute_api, we're not passing an elevated context to confirm_resize when we try to delete instances in RESIZED.

The fix to bug 1056601 didn't fully address the issue.

Chris Behrens (cbehrens) on 2012-10-26
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Chris Behrens (cbehrens)
status: New → In Progress
tags: added: folsom-backport-potential

Reviewed: https://review.openstack.org/14872
Committed: http://github.com/openstack/nova/commit/14e2ed3ace769c4deaca3c48a2fa59863f637a5f
Submitter: Jenkins
Branch: master

commit 14e2ed3ace769c4deaca3c48a2fa59863f637a5f
Author: Chris Behrens <email address hidden>
Date: Thu Oct 25 22:09:55 2012 -0700

    Fix use of elevated context for resize methods

    elevated contexts were being passed over RPC to confirm_resize,
    revert_resize, and finish_revert_resize methods. If those methods need
    to elevate context, they should do so themselves.

    There was 1 case (when deleting an instance in RESIZED) when we'd send a
    non-elevated context to confirm_resize(). This would fail because the
    migration_get() call there requires admin context and confirm_resize()
    on the manager side did not elevate the context itself.

    This fixes bug 1071600 and removes sending elevated contexts for these
    methods over RPC.

    (Ultimately we need some work to make the migration* DB API calls verify
    project_id vs requiring admin context..)

    Change-Id: I907889502f19fba8059253e52dca084a123016e2

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-11-21
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
tags: removed: folsom-backport-potential
Vish Ishaya (vishvananda) wrote :

This is a tricky backport and probably should be fixed via just passing an elevated context in _delete

Reviewed: https://review.openstack.org/16724
Committed: http://github.com/openstack/nova/commit/85ccf80ac208c86800cea6b293abd51910def9bb
Submitter: Jenkins
Branch: stable/folsom

commit 85ccf80ac208c86800cea6b293abd51910def9bb
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Nov 21 18:11:48 2012 -0800

    Pass elevated context to confirm resize

    The actual fix for bug 1071600 is a bit too invasive to backport,
    so this is a simpler fix that only changes one line.

    Change-Id: I8901056b6216d3d1b945dbc06a66b5354c185076

Changed in nova (Ubuntu):
status: New → Fix Released
Changed in nova (Ubuntu Quantal):
status: New → Confirmed

Hello Chris, or anyone else affected,

Accepted nova into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/2012.2.1+stable-20121212-a99a802e-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nova (Ubuntu Quantal):
status: Confirmed → Fix Committed
tags: added: verification-needed
Launchpad Janitor (janitor) wrote :
Download full text (8.3 KiB)

This bug was fixed in the package nova - 2012.2.1+stable-20121212-a99a802e-0ubuntu1

---------------
nova (2012.2.1+stable-20121212-a99a802e-0ubuntu1) quantal-proposed; urgency=low

  * Ubuntu updates:
    - debian/control: Ensure novaclient is upgraded with nova,
      require python-keystoneclient >= 1:2.9.0. (LP: #1073289)
    - d/p/avoid_setuptools_git_dependency.patch: Refresh.
  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-5625.patch: [a99a802]
  * Resynchronize with stable/folsom (b55014ca) (LP: #1085255):
    - [a99a802] create_lvm_image allocates dirty blocks (LP: #1070539)
    - [670b388] RPC exchange name defaults to 'openstack' (LP: #1083944)
    - [3ede373] disassociate_floating_ip with multi_host=True fails
      (LP: #1074437)
    - [22d7c3b] libvirt imagecache should handle shared image storage
      (LP: #1075018)
    - [e787786] Detached and deleted RBD volumes remain associated with insance
      (LP: #1083818)
    - [9265eb0] live_migration missing migrate_data parameter in Hyper-V driver
      (LP: #1066513)
    - [3d99848] use_single_default_gateway does not function correctly
      (LP: #1075859)
    - [65a2d0a] resize does not migrate DHCP host information (LP: #1065440)
    - [102c76b] Nova backup image fails (LP: #1065053)
    - [48a3521] Fix config-file overrides for nova-dhcpbridge
    - [69663ee] Cloudpipe in Folsom: no such option: cnt_vpn_clients
      (LP: #1069573)
    - [6e47cc8] DisassociateAddress can cause Internal Server Error
      (LP: #1080406)
    - [22c3d7b] API calls to dis-associate an auto-assigned floating IP should
      return proper warning (LP: #1061499)
    - [bd11d15] libvirt: if exception raised during volume_detach, volume state
      is inconsistent (LP: #1057756)
    - [dcb59c3] admin can't describe all images in ec2 api (LP: #1070138)
    - [78de622] Incorrect Exception raised during Create server when metadata
      over 255 characters (LP: #1004007)
    - [c313de4] Fixed IP isn't released before updating DHCP host file
      (LP: #1078718)
    - [f4ab42d] Enabling Return Reservation ID with XML create server request
      returns no body (LP: #1061124)
    - [3db2a38] 'BackupCreate' should accept rotation parameter greater than or
      equal to zero (LP: #1071168)
    - [f7e5dde] libvirt reboot sometimes fails to reattach volumes
      (LP: #1073720)
    - [ff776d4] libvirt: detaching volume may fail while terminating other
      instances on the same host concurrently (LP: #1060836)
    - [85a8bc2] Used instance uuid rather than id in remove-fixed-ip
    - [42a85c0] Fix error on invalid delete_on_termination value
    - [6a17579] xenapi migrations fail w/ swap (LP: #1064083)
    - [97649b8] attach-time field for volumes is not updated for detach volume
      (LP: #1056122)
    - [8f6a718] libvirt: rebuild is not using kernel and ramdisk associated with
      the new image (LP: #1060925)
    - [fbe835f] live-migration and volume host assignement (LP: #1066887)
    - [c2a9150] typo prevents volume_tmp_dir flag from working (LP: #1071536)
    - [93efa21] Instances deleted during spawn leak network allocations
      (LP: #1068716)
    - [ebabd02] After restartin...

Read more...

Changed in nova (Ubuntu Quantal):
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-04-04
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers