nova-novncproxy needs additional arguments to websickify constructor

[lin_victor]

I installed the OpenStack with devstack, and when running "cd /opt/stack/noVNC && ./utils/nova-novncproxy --config-file /etc/nova/nova.conf --web .", error occurred, which is as follows:
Traceback (most recent call last):
  File "./utils/nova-novncproxy", line 151, in <module>
    wrap_cmd=None)
  File "./utils/nova-novncproxy", line 78, in __init__
    wsproxy.WebSocketProxy.__init__(self, *args, **kwargs)
  File "/opt/stack/noVNC/utils/wsproxy.py", line 48, in __init__
    self.unix_target = kwargs.pop('unix_target')
KeyError: 'unix_target'

The bug is the same with Bug #1031998, and I also checked the reviewed code in https://review.openstack.org/#/c/12500/
I found the following line of code in /opt/stack/noVNC/utils/nova-novncproxy, which is already up-to-date, has not been modified yet.
        wsproxy.WebSocketProxy.__init__(self,*args, **kwargs)

After I modified this line into the following line, the bug is fixed. I wonder whether it is a bug, or I was wrong installing OpenStack?
        wsproxy.WebSocketProxy.__init__(self,unix_target=None,
                                        target_cfg=None,
                                        ssl_target=None,*args, **kwargs)

[Thierry Carrez (ttx)]

You're probably installing an old version that does not have the fix. Marking as duplicate

[Thierry Carrez (ttx)]

Fix is committed: https://github.com/openstack/nova/blob/master/bin/nova-novncproxy#L75

[Can Zhang (acme-ican)]

the patch fixed file /opt/stack/nova/bin/nova-novncproxy, but /opt/stack/noVNC/utils/nova-novncproxy is not fixed (installed using devstack)

I wonder if this is a bug of openstack or of devstack.

[Thierry Carrez (ttx)]

devstack draws by default from https://github.com/kanaka/noVNC.git which does not include the fix. You can propose it there: https://github.com/kanaka/noVNC

The proper way to use nova-novncproxy would be to start the version in /opt/stack/nova/bin/nova-novncproxy