OpenStack Compute (nova)

nova-novncproxy needs an additional argument to websickify constructor

Bug #1031998 reported by Dean Troyer
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Thierry Carrez
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Current websockify used by nova-novncproxy (https://github.com/kanaka/websockify/) has an additional required argument (target_cfg) for websockify.WebSocketProxy.__init__() as of https://github.com/kanaka/websockify/commit/26e80952447b651b649ef444c41c5092113d5e19 (originally added as target_list in https://github.com/kanaka/websockify/commit/e17e1158d85b5955ca740f4b97643192e1d67eb0).

Revision history for this message
Anthony Young (sleepsonthefloor) wrote :

This pull req should fix this: https://github.com/kanaka/websockify/pull/53

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12500

Changed in nova:
assignee: nobody → Thierry Carrez (ttx)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12500
Committed: http://github.com/openstack/nova/commit/76068c27d964bde71870e15c286a97971a85b347
Submitter: Jenkins
Branch: master

commit 76068c27d964bde71870e15c286a97971a85b347
Author: Thierry Carrez <email address hidden>
Date: Thu Sep 6 16:31:00 2012 +0200

    Add missing argument to novncproxy websockify call

    Current websockify constructor in nova-novncproxy requires
    target_path to be explicitely set. This commit adds the missing
    parameter. Fixes bug 1031998.

    Change-Id: I05e346b5df5bc1501b55ff606fc4cefdda889d60

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.