Comment 20 for bug 1016633

Reviewed: https://review.openstack.org/184027
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c5e2d4b6b4dfa64f898249d6ed871cf6d41c58a2
Submitter: Jenkins
Branch: master

commit c5e2d4b6b4dfa64f898249d6ed871cf6d41c58a2
Author: Hans Lindgren <email address hidden>
Date: Thu Apr 23 22:43:24 2015 +0200

    Remove unused provider firewall rules functionality in nova

    Provider firewall rules functionality is not in use and hasn't been
    for a very long time. The api for this was removed in [1] and db api
    methods for adding/removing rows in the associated db table have not
    been used since.

    Stop refreshing those rules as it is essentially a no-op and indeed a
    costly one that includes a rpc round trip to the conductor to get
    back an always empty db result. This should have a positive impact on
    instance boot performance since the conductor call happens to live
    inside an externally syncronized block of code.

    Removes related compute rpcapi/manager code that were missed in a
    recent cleanup[2]. Since this functionality hasn't been in use since
    Havana timeframe(!), it should be fairly safe to remove without first
    deprecating it.

    Also removes the now unused virtapi method provider_fw_rule_get_all()
    and the virtapi itself from virt firewall driver initialization.

    [1] Commit: 62d5fae8d11b6403f9a63a709270ffafebb7ef09
    [2] Commit: e6f7d8041783a0b3c740559d97b8d40b3568f214

    Change-Id: Ifbb2514b9bc1445eaa07dcfe172c7405fd1a58f7
    Partial-Bug: #1016633