Comment 13 for bug 1008866

> I understand that we want a better soution, but I think your patch is too large to
> backport into stable/essex and therefore should be
> done against the new cinder project.

Yes I understand too. Unfortunately, proposed simple solution will not fix this regression of this feature for production environment with many nova-volume nodes. But, yes you can workaround "the error/exception in log" by this way (until volume space is not exhausted). In our use-case we will rollback the simple fix and apply our fix in stable/essex release in our build of OpenStack.

> The simple solution is appropriate for an essex backport.
> The more complex solution can be done in cinder, as it still requires some cleanup.

Yes completely agree, cleanups are needed for future release. This patch was created in hurry without thinking about best practices.

> For example, the attach to snapshot code is essentially the same as
> attach to volume code and should be put into a little library of some sort.
> Also, I couldn't tell from the patch if it is using discovery by default,
> but if so it should be storing provider_location in the snapshots as
> well and connecting via an initialize_connection call in the same
> way it does for volumes.

I completely agree.

> In other words, this is a large set of changes that should be planned coherently in the cinder project.

Yes, again I completely agree without comments because review comments was expected ;). Please fell free to re-factor this patch/code for cinder project. I will be happy man whit the best solution/code :). This patch was for essex = do it without any DB modifications, without rewriting current functions if it is possible, do it immediately because this regression was blocking issue for our Private Cloud based on Essex.