Comment 12 for bug 475373

On Tuesday 08,December,2009 04:29 AM, Cristian KLEIN wrote:
> On 07/12/2009 21:12, Chow Loong Jin wrote:
>> On Tuesday 08,December,2009 04:03 AM, Cristian KLEIN wrote:
>>> Before, it "failed" i.e. the function returned "this window is not a
>>> panel". The patch makes it returns "this is a panel, but I warn you,
>>> it's not a top-panel".
>>>
>> But my point is that it *is* a top-panel. And notify-osd does not bother with
>> non-top panels, or in the case of your patch, non-top-or-bottom panels.
>>
>> Please correct me if I'm mistaken.
>
> What exactly do you mean with "non-top-or-bottom panels"? Do you mean
> "lateral" panels? I don't know how many people use something like that.
> And anyway, they are filtered by the next few lines of code:
>
> if (frame.width < frame.height)
> goto failed;
>
I mean panels which notify-osd ignore when figuring out where to place
notifications. I'm not sure exactly what type of panel notify-osd is supposed to
ignore, but I'm very sure that a panel spanning the width of my right display
should *not* be ignored.

Speaking of which, yet another related issue would be having multiple panels at
the top. If you add a second panel to the top, just under the first panel,
notify-osd will render notifications on top of that panel, which isn't really
desirable, I should think.

--
Kind regards,
Chow Loong Jin (GPG: 0x8F02A411)
Ubuntu Contributing Developer