FileUtils.count_music_files () has side effects
Bug #1336846 reported by
Sergey "Shnatsel" Davidoff
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Noise |
Confirmed
|
Undecided
|
Unassigned | ||
Bug Description
Noise.FileUtils
This should be fixed. Counting function should not have any side effects (and should only work with a read-only view of the collection). And whatever this function really does should be split into a properly named function.
It is exposed on the plugin API so fixing it directly will break the external API/ABI, but we officially don't have plugin API stability yet (bug #1336493).
(I'm not that good at Vala. We figured this out together with xapantu).
| description: | updated |
| description: | updated |
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | #1 |
| description: | updated |
| tags: | added: library-management |
| Changed in noise: | |
| assignee: | nobody → PerfectCarl (name-is-carl) |
| status: | New → In Progress |
| Changed in noise: | |
| assignee: | PerfectCarl (name-is-carl) → nobody |
| status: | In Progress → Confirmed |
To post a comment you must log in.
Some of the issues are fixed by lp:~shnatsel-unprivileged/noise/import-optimization-and-cleanup so I'm updating description accordingly.