Catch broad exception in methods used in FixedIntervalLoopingCall
Unlike other places where it might make sense to catch specific
exceptions, methods that are used to check L3 and DHCP agents
liveness via FixedIntervalLoopingCall should never allow exceptions
to leak to calling method and interrupt the loop.
Further improvement of FixedIntervalLoopingCall might be needed,
but for the sake of easy backporting it makes sense to fix the issue
in neutron before pushing refactoring to 3rd-party library.
Reviewed: https:/ /review. openstack. org/185722 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=ae8c1c5f80f d4fb7b4ab116677 f4cff988c67cf1
Committed: https:/
Submitter: Jenkins
Branch: master
commit ae8c1c5f80fd4fb 7b4ab116677f4cf f988c67cf1
Author: Eugene Nikanorov <email address hidden>
Date: Tue May 26 20:17:20 2015 +0400
Catch broad exception in methods used in FixedIntervalLo opingCall
Unlike other places where it might make sense to catch specific opingCall should never allow exceptions
exceptions, methods that are used to check L3 and DHCP agents
liveness via FixedIntervalLo
to leak to calling method and interrupt the loop.
Further improvement of FixedIntervalLo opingCall might be needed,
but for the sake of easy backporting it makes sense to fix the issue
in neutron before pushing refactoring to 3rd-party library.
Change-Id: I6a61e99a6f4e44 5e26ea4a9923b47 e35559e5703
Closes-Bug: #1458119