Comment 2 for bug 2065460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (master)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/919229
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/9c2274e813fe167b79b1ceb7f8da188e251cc6ef
Submitter: "Zuul (22348)"
Branch: master

commit 9c2274e813fe167b79b1ceb7f8da188e251cc6ef
Author: Terry Wilson <email address hidden>
Date: Fri May 10 15:00:05 2024 -0500

    Don't create an OVSDB connection per API request

    Using the default ovsdbapp.backend.ovs_idl.Backend behavior which
    stores the ovsdb_connection on the Backend class itself ensures
    that when Octavia does the imports necessary for instantiating the
    driver, that the ovsdb_connection will remain on the class even
    though the instances are deleted. This will allow us to reuse the
    OVSDB connection between APIs despite octavia-api knowing nothing
    about it.

    In addition, __del__() can called from any thread by the garbage
    collector, and so it was possible that thread.join() would be
    called by the thread we were in, throwing an Exception and
    preventing cleanup.

    Co-authored-by: Gregory Thiemonge <email address hidden>
    Co-authored-by: Ihar Hrachyshka <email address hidden>
    Co-authored-by: Jakub Libosvar <email address hidden>

    Closes-Bug: #2065460
    Closes-Bug: #2065459

    Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05