commit 10af328885ac0f85f161c454dd53463cee57bb23
Author: Brian Haley <email address hidden>
Date: Tue Mar 5 11:59:05 2024 -0500
Use the system-dependent string for IP protocol 4
iptables-save uses a system-dependent value, usually that
found in /etc/protocols, when 'ipip' is given as the
security group protocol. The intent is to always use the
string value for IP protocol '4', as iptables-save has no
'-n' flag to print values numerically.
This updates a previous change (793dfb04d) that hard-coded
that string to 'ipencap', which broke CentOS/Fedora, which
uses 'ipv4'.
For this reason we cannot hard-code anything in neutron-lib,
this needs to be added dynamically, so this one-line change
needs to stay here, and effectively closes the bug.
Closes-bug: #2054324
Change-Id: Ic40b539c9ef5cfa4cbbd6575e19e653342e8342b
(cherry picked from commit cd1d191e335dca707ac9324fd81e642cb453a6cf)
Reviewed: https:/ /review. opendev. org/c/openstack /neutron/ +/911605 /opendev. org/openstack/ neutron/ commit/ 10af328885ac0f8 5f161c454dd5346 3cee57bb23
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/2023.1
commit 10af328885ac0f8 5f161c454dd5346 3cee57bb23
Author: Brian Haley <email address hidden>
Date: Tue Mar 5 11:59:05 2024 -0500
Use the system-dependent string for IP protocol 4
iptables-save uses a system-dependent value, usually that
found in /etc/protocols, when 'ipip' is given as the
security group protocol. The intent is to always use the
string value for IP protocol '4', as iptables-save has no
'-n' flag to print values numerically.
This updates a previous change (793dfb04d) that hard-coded
that string to 'ipencap', which broke CentOS/Fedora, which
uses 'ipv4'.
For this reason we cannot hard-code anything in neutron-lib,
this needs to be added dynamically, so this one-line change
needs to stay here, and effectively closes the bug.
Closes-bug: #2054324 a4cbbd6575e19e6 53342e8342b 07ac9324fd81e64 2cb453a6cf)
Change-Id: Ic40b539c9ef5cf
(cherry picked from commit cd1d191e335dca7