neutron

[OVN][Trunk] The cold migration process is broken since patch 882581

Bug #2033887 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The patch [1] is incorrectly handling the port binding of the subports. This is a more complex operation than just updating the "PortBinding" object. In order to change the port binding host ID, it is needed to remove all "PortBinding" and "PortBindingLevels" registers and create new ones pointing to the new host ID.

This patch is also breaking the cold migration process in ML2/OVN environments with Trunk ports. The subports are not receiving the DHCP information because OVN is not creating the DHCP flows that attend to the DHCP requests. For example [2].

The recommended action is to revert the mentioned patch.

[1]https://review.opendev.org/c/openstack/neutron/+/882581
[2]https://paste.opendev.org/show/bVnaVLVP9fkrm0QlXtYc/

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/893444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/893445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/893446

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/893447

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/893448

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/893449

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/893552

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/893553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/893554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/893555

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/893556

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/893557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893552
Committed: https://opendev.org/openstack/neutron/commit/34e441e06cd57c95ce4c5ef155103f356324c56c
Submitter: "Zuul (22348)"
Branch: master

commit 34e441e06cd57c95ce4c5ef155103f356324c56c
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:50:35 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 7ed79c1f7890456488a4b44769ed84fea23c9a39.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: I642c3eb1771463db73248a8c50c0db6f7467a6d5
    Partial-Bug: #2033887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893553
Committed: https://opendev.org/openstack/neutron/commit/7f51901d4775a3f696ae7cca6e8d59cf5009fe31
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 7f51901d4775a3f696ae7cca6e8d59cf5009fe31
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:52:06 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 6dc93c5072f586ffbf245e4740f314d3de1e95f1.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Iab5b8de1c997812600d35691ad9e51e309a795a3
    Partial-Bug: #2033887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893554
Committed: https://opendev.org/openstack/neutron/commit/f3409f6b6ccc624cea284bf6f76594afd1bee688
Submitter: "Zuul (22348)"
Branch: stable/zed

commit f3409f6b6ccc624cea284bf6f76594afd1bee688
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:52:26 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 1ce5ef7f83776512487980e3d1b0fd1364ffb0f1.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: I779b13f10f20f95c4963e0e1667566e4589beb76
    Partial-Bug: #2033887

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893556
Committed: https://opendev.org/openstack/neutron/commit/de424f5991b6fff9d0436aa29f138a3375d0947a
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit de424f5991b6fff9d0436aa29f138a3375d0947a
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:52:42 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 82f06feebe190064c7a37cc30c144de71052f920.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: If248bcb8b1088edf5ddde20f84cd36cc27c98107
    Partial-Bug: #2033887

tags: added: in-stable-yoga
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893555
Committed: https://opendev.org/openstack/neutron/commit/0864358f07bbe1155ec0e5525aebdb9c81693bc2
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0864358f07bbe1155ec0e5525aebdb9c81693bc2
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:52:35 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 6d3c29723e5d48eefd6ba73dc152ed6c99f70ffa.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: I97969803b736c3338f42cb1988941322d08df13a
    Partial-Bug: #2033887

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893557
Committed: https://opendev.org/openstack/neutron/commit/15fbae603f5d4820fad634b1dcdb1e84bbfe69a9
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 15fbae603f5d4820fad634b1dcdb1e84bbfe69a9
Author: Rodolfo Alonso <email address hidden>
Date: Tue Sep 5 10:52:50 2023 +0000

    Revert "[OVN][Trunk] Set the subports correct host during live migration"

    This reverts commit 9f677abd1e09bb5e9a7d25aac5f42bc49597c92c.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ie05d8b5c89b97c23043effd2f1a1faac9cb7aa99
    Partial-Bug: #2033887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/894790

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/894791

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/894792

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/894793

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/894794

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/xena)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/893448

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/zed)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/893449

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/yoga)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/893446

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/2023.1)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/893445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/wallaby)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/893444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-tempest-plugin (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/895152

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-tempest-plugin (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/895152
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/370f71e9877fad13883413225bf25051c0c9c391
Submitter: "Zuul (22348)"
Branch: master

commit 370f71e9877fad13883413225bf25051c0c9c391
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Sep 9 21:33:55 2023 +0000

    Mark "test_subport_connectivity_soft_reboot" as unstable

    This issue is related to:
    * https://bugs.launchpad.net/neutron/+bug/2033887: the patches
      previously merged in the Neutron repository [1][2] should be
      reverted.
    * https://bugs.launchpad.net/neutron/+bug/2024160: this issue
      is still present.

    [1]https://review.opendev.org/c/openstack/neutron/+/882581
    [2]https://review.opendev.org/c/openstack/neutron/+/888776

    Change-Id: I9d8d76810d15913c29610464ab1b8fa34863aaf6
    Related-Bug: #2024160
    Related-Bug: #2033887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/895899

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893447
Committed: https://opendev.org/openstack/neutron/commit/1b034f8d62091724a6fb639f34c2f8936329b501
Submitter: "Zuul (22348)"
Branch: master

commit 1b034f8d62091724a6fb639f34c2f8936329b501
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/895899
Committed: https://opendev.org/openstack/neutron/commit/d28bcf0fe1648cfdded5e3bc38200b6d1315f42f
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit d28bcf0fe1648cfdded5e3bc38200b6d1315f42f
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887
    (cherry picked from commit 1b034f8d62091724a6fb639f34c2f8936329b501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894791
Committed: https://opendev.org/openstack/neutron/commit/93f223f8c0a8ad0709418820c96e22161a198313
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 93f223f8c0a8ad0709418820c96e22161a198313
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887
    (cherry picked from commit 1b034f8d62091724a6fb639f34c2f8936329b501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894792
Committed: https://opendev.org/openstack/neutron/commit/904db03f3e9c6e9bd727f7448217a164daba2c77
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 904db03f3e9c6e9bd727f7448217a164daba2c77
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887
    (cherry picked from commit 1b034f8d62091724a6fb639f34c2f8936329b501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894793
Committed: https://opendev.org/openstack/neutron/commit/cf096344b07b80524c3888e44e0b895465598a74
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit cf096344b07b80524c3888e44e0b895465598a74
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887
    (cherry picked from commit 1b034f8d62091724a6fb639f34c2f8936329b501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0rc2

This issue was fixed in the openstack/neutron 23.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894794
Committed: https://opendev.org/openstack/neutron/commit/b08315d3d374d6d5e8217a870510fca230588afd
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b08315d3d374d6d5e8217a870510fca230588afd
Author: Rodolfo Alonso <email address hidden>
Date: Fri Sep 1 11:43:24 2023 +0000

    Revert "[OVN][Trunk] Add port binding info on subport when parent is bound"

    This reverts commit 955e621167987626806128d259a29d4e62acf102.

    Reason for revert: the port binding handling done in this patch is
    incorrect and leads to issues during the cold migration process with
    trunk ports in ML2/OVN.

    Change-Id: Ifc2d37e2042fad43dd838821953defd99a5f8665
    Closes-Bug: #2033887
    (cherry picked from commit 1b034f8d62091724a6fb639f34c2f8936329b501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.1.0

This issue was fixed in the openstack/neutron 22.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.5.0

This issue was fixed in the openstack/neutron 20.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.2.0

This issue was fixed in the openstack/neutron 21.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0b1

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/wallaby)

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/894790
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron xena-eom

This issue was fixed in the openstack/neutron xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.