Comment 11 for bug 2028846

Reviewed: https://review.opendev.org/c/openstack/neutron/+/907402
Committed: https://opendev.org/openstack/neutron/commit/a355d2a0d55b62e4337d5c71dc4c4049883c59c3
Submitter: "Zuul (22348)"
Branch: master

commit a355d2a0d55b62e4337d5c71dc4c4049883c59c3
Author: Slawek Kaplonski <email address hidden>
Date: Thu Feb 1 11:36:29 2024 +0100

    Log warning about port forwardings that won't work properly

    This is follow up patch to [1] in which was added warning about
    incompatible configuration of the vlan/flat networks allowed as tenant
    networks, distributed routing and port forwardings.

    In this new patch similar warning is logged every time when port
    forwarding is created using router which have actually connected vlan or
    flat networks as "internal networks" (external gateway network is fine)
    and when distributed routing is enabled in the Neutron config.

    This patch additionally adds "neutron:is_ext_gw" flag to the
    Logical_Router_Port's external_ids. With that it's easier to check if
    network is used as gateway network (no checks needed) or not (checks are
    perfomed and warning may be logged).

    [1] https://review.opendev.org/c/openstack/neutron/+/892542

    Related-Bug: #2028846
    Change-Id: I101128bdb421ec83df5cdcb0d486cbafbbca2ce5