Comment 4 for bug 2004004

Revision history for this message
Rafael Weingartner (rafaelweingartner) wrote :

Rodolfo,
To build on the, the link you posted, the code that is introduce there does not block the use case described by Florian.

We can see in [1] that the validation performed in [2] would only affect situations where one defines the gateway (GW) of the network as the IP used to address the broadcast or the network itself. Therefore, IPs outside of the CIDR are not validated.

Moreover, the error message displayed in [3] is a little bit misleading. The code is blocking the use of the IP address used to reference the network and broadcast domain, and not IPs that are outside of the CIDR. I will propose a patch to address that.

Moreover, with respect to Florian's use case, there is already code upstream to handle such situations, as one can see in [4]. The that happened with Florian only exists because he is not using upstream Neutron version.

[1] https://github.com/openstack/neutron/blob/e6eeb700c88499281d3924de6d8fd009d5dc09b7/neutron/ipam/utils.py#L37

[2] https://github.com/openstack/neutron/blob/e6eeb700c88499281d3924de6d8fd009d5dc09b7/neutron/ipam/requests.py#L119

[3] https://github.com/openstack/neutron/blob/e6eeb700c88499281d3924de6d8fd009d5dc09b7/neutron/ipam/requests.py#L120

[4] https://github.com/openstack/neutron/blob/e6eeb700c88499281d3924de6d8fd009d5dc09b7/neutron/agent/l3/ha_router.py#L294