Importing some modules lead to registering config options that may
collide with config options from a project that calls the import. This
patch wraps the side effect that registers config options into a
function that needs to be called in case the caller wants to register
the options.
This solution is also not perfect as it guards the common options to be
registered only once even if the function is called multiple times. This
is to solve problems in unittests, ideally we should always call the
function just once even in our testing suites.
Resolves-Bug: #1968606
Change-Id: Ic1532eb8de887ff1b1085206df11f53e22f7f524
Signed-off-by: Jakub Libosvar <email address hidden>
Reviewed: https:/ /review. opendev. org/c/openstack /neutron/ +/837392 /opendev. org/openstack/ neutron/ commit/ 4d3a274765a364f 6f7b6bff163d6f7 110bdbdbbe
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 4d3a274765a364f 6f7b6bff163d6f7 110bdbdbbe
Author: Jakub Libosvar <email address hidden>
Date: Mon Apr 11 21:45:49 2022 +0000
Don't register config options on imports
Importing some modules lead to registering config options that may
collide with config options from a project that calls the import. This
patch wraps the side effect that registers config options into a
function that needs to be called in case the caller wants to register
the options.
This solution is also not perfect as it guards the common options to be
registered only once even if the function is called multiple times. This
is to solve problems in unittests, ideally we should always call the
function just once even in our testing suites.
Resolves-Bug: #1968606 f1b1085206df11f 53e22f7f524
Change-Id: Ic1532eb8de887f
Signed-off-by: Jakub Libosvar <email address hidden>