[sriov]: set_device_rate() takes 3 positional arguments but 4 were given

Bug #1968206 reported by Lajos Katona
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Lajos Katona

Bug Description

https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19 (
[SR-IOV] Fix QoS extension to set min/max values) seems introduced an issue with sriov ports, see the below traceback:
https://paste.opendev.org/show/bhQw8reMUZIQNSiWmDHc/

The original bug: https://bugs.launchpad.net/neutron/+bug/1962844

The issue seems to be that the signature was not changed everywhere to the new dict format.

Changed in neutron:
assignee: nobody → Lajos Katona (lajos-katona)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/837092

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/837107

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/837108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/837109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/837110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/837111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837092
Committed: https://opendev.org/openstack/neutron/commit/837fda7566fc8d2344d68468be7717563e13008c
Submitter: "Zuul (22348)"
Branch: master

commit 837fda7566fc8d2344d68468be7717563e13008c
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837107
Committed: https://opendev.org/openstack/neutron/commit/480bd3f563cbae7df0b50f1bf2ea5c099b0f3343
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 480bd3f563cbae7df0b50f1bf2ea5c099b0f3343
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837108
Committed: https://opendev.org/openstack/neutron/commit/40c3671339b4ee6fb8e7e8b32c2192adb7b921f9
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 40c3671339b4ee6fb8e7e8b32c2192adb7b921f9
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837109
Committed: https://opendev.org/openstack/neutron/commit/9a94e2855a05aebcda361a5c4cecbfcb106797a6
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9a94e2855a05aebcda361a5c4cecbfcb106797a6
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

tags: added: in-stable-wallaby
tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837110
Committed: https://opendev.org/openstack/neutron/commit/7caeebbbc31a92841a6354a1a20320f31780c51c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 7caeebbbc31a92841a6354a1a20320f31780c51c
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837111
Committed: https://opendev.org/openstack/neutron/commit/13bb2554da87671fa6bfea008039da53d5a07de2
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 13bb2554da87671fa6bfea008039da53d5a07de2
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.4.0

This issue was fixed in the openstack/neutron 17.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.3.0

This issue was fixed in the openstack/neutron 18.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.2.0

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.1.0

This issue was fixed in the openstack/neutron 20.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.0.0.0rc1

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.