neutron

[SR-IOV] QoS extension doesn't set max-tx-rate and min-tx-rate in the same port

Bug #1962844 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

The SR-IOV agent extension can handle max-BW and min-BW QoS rules, but currently doesn't apply both to the same port at the same time.

The problem is how the Pyroute2 command is used. The "ip link" command allows to set "rate" and "min" rules in two independent commands. E.g.:
$ ip link set dev enp196s0f0 vf 5 rate 30
$ ip l show dev enp196s0f0
  vf 5 link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps

$ ip link set dev enp196s0f0 vf 5 min 20
$ ip l show dev enp196s0f0
  vf 5 link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps, min_tx_rate 20Mbps

The second command setting the min-BW rate doesn't remove the max-BW rate.

However, the Pyroute2 command to set the VF rates requires to set both.
> ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100, 'min_tx_rate': 20})

If one key is missing, the value will be set to zero (the QoS rule will be removed). E.g.:
> ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100}) --> this command will set a max-BW of 100Mbps and will remove any min-BW rule already defined.

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/831830

Changed in neutron:
status: New → In Progress
Brian Haley (brian-haley)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/831830
Committed: https://opendev.org/openstack/neutron/commit/cdff281f642511ea3d0e077dbe885ec955208a7a
Submitter: "Zuul (22348)"
Branch: master

commit cdff281f642511ea3d0e077dbe885ec955208a7a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 3 02:57:07 2022 +0000

    [SR-IOV] Fix QoS extension to set min/max values

    "ip link" commands allow to define VF rates independently.
    That means, first "rate" (max BW) can be set and in a second
    command "min" (min BW) (check LP bug description).

    However Pyroute2 command to set the VF rates requires to set both.
    If one value is missing ("min_tx_rate", "max_tx_rate"), the library
    sets this value to 0; in other words, the value is deleted.

    The Pyroute2 structures are built depending on the parameter names.
    In this case, {'vf': {'rate': ...}} will create a "vf_rate" [1]
    nla structure, that requires "min_tx_rate" and "max_tx_rate".
    This is part of the full structure passed to the "iproute" library
    [2].

    This is an example of code that only sets the "max_tx_rate" for
    the 15th VF of "enp196s0f0":
      $ from neutron.plugins.ml2.drivers.mech_sriov.agent import pci_lib
        pci = pci_lib.PciDeviceIPWrapper("enp196s0f0")
        pci.set_vf_rate(15, {'max_tx_rate': 10})

    The "msg" [3] (structure passed to "iproute" library) is this:
    https://paste.opendev.org/show/b2FZBOebGOCHMrYhPr6X/. The
    "min_tx_rate" is set to the default value 0.

    This patch reads first the existing rates ("min_tx_rate",
    "max_tx_rate") and populates the command parameters accordingly.

    [1]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/netlink/rtnl/ifinfmsg/__init__.py#L712-L717
    [2]https://github.com/shemminger/iproute2/blob/c8d9d92544668922dc5aa06d2491f42b837b9361/ip/ipaddress.c#L454-L470
    [3]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/iproute/linux.py#L1499

    Closes-Bug: #1962844
    Change-Id: Ibbb6d938355440c42850812e368224b76b1fce19

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/832761

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/832762

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/832764

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/832765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/832766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/832761
Committed: https://opendev.org/openstack/neutron/commit/0c9e9b27527d5ee5f3ffd503bf0dfbe0d0ed7e40
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0c9e9b27527d5ee5f3ffd503bf0dfbe0d0ed7e40
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 3 02:57:07 2022 +0000

    [SR-IOV] Fix QoS extension to set min/max values

    "ip link" commands allow to define VF rates independently.
    That means, first "rate" (max BW) can be set and in a second
    command "min" (min BW) (check LP bug description).

    However Pyroute2 command to set the VF rates requires to set both.
    If one value is missing ("min_tx_rate", "max_tx_rate"), the library
    sets this value to 0; in other words, the value is deleted.

    The Pyroute2 structures are built depending on the parameter names.
    In this case, {'vf': {'rate': ...}} will create a "vf_rate" [1]
    nla structure, that requires "min_tx_rate" and "max_tx_rate".
    This is part of the full structure passed to the "iproute" library
    [2].

    This is an example of code that only sets the "max_tx_rate" for
    the 15th VF of "enp196s0f0":
      $ from neutron.plugins.ml2.drivers.mech_sriov.agent import pci_lib
        pci = pci_lib.PciDeviceIPWrapper("enp196s0f0")
        pci.set_vf_rate(15, {'max_tx_rate': 10})

    The "msg" [3] (structure passed to "iproute" library) is this:
    https://paste.opendev.org/show/b2FZBOebGOCHMrYhPr6X/. The
    "min_tx_rate" is set to the default value 0.

    This patch reads first the existing rates ("min_tx_rate",
    "max_tx_rate") and populates the command parameters accordingly.

    [1]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/netlink/rtnl/ifinfmsg/__init__.py#L712-L717
    [2]https://github.com/shemminger/iproute2/blob/c8d9d92544668922dc5aa06d2491f42b837b9361/ip/ipaddress.c#L454-L470
    [3]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/iproute/linux.py#L1499

    Closes-Bug: #1962844
    Change-Id: Ibbb6d938355440c42850812e368224b76b1fce19
    (cherry picked from commit cdff281f642511ea3d0e077dbe885ec955208a7a)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/832762
Committed: https://opendev.org/openstack/neutron/commit/1cadfc84a5650758153385bb52dea7be713c4184
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1cadfc84a5650758153385bb52dea7be713c4184
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 3 02:57:07 2022 +0000

    [SR-IOV] Fix QoS extension to set min/max values

    "ip link" commands allow to define VF rates independently.
    That means, first "rate" (max BW) can be set and in a second
    command "min" (min BW) (check LP bug description).

    However Pyroute2 command to set the VF rates requires to set both.
    If one value is missing ("min_tx_rate", "max_tx_rate"), the library
    sets this value to 0; in other words, the value is deleted.

    The Pyroute2 structures are built depending on the parameter names.
    In this case, {'vf': {'rate': ...}} will create a "vf_rate" [1]
    nla structure, that requires "min_tx_rate" and "max_tx_rate".
    This is part of the full structure passed to the "iproute" library
    [2].

    This is an example of code that only sets the "max_tx_rate" for
    the 15th VF of "enp196s0f0":
      $ from neutron.plugins.ml2.drivers.mech_sriov.agent import pci_lib
        pci = pci_lib.PciDeviceIPWrapper("enp196s0f0")
        pci.set_vf_rate(15, {'max_tx_rate': 10})

    The "msg" [3] (structure passed to "iproute" library) is this:
    https://paste.opendev.org/show/b2FZBOebGOCHMrYhPr6X/. The
    "min_tx_rate" is set to the default value 0.

    This patch reads first the existing rates ("min_tx_rate",
    "max_tx_rate") and populates the command parameters accordingly.

    [1]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/netlink/rtnl/ifinfmsg/__init__.py#L712-L717
    [2]https://github.com/shemminger/iproute2/blob/c8d9d92544668922dc5aa06d2491f42b837b9361/ip/ipaddress.c#L454-L470
    [3]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/iproute/linux.py#L1499

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_eswitch_manager.py

    Closes-Bug: #1962844
    Change-Id: Ibbb6d938355440c42850812e368224b76b1fce19
    (cherry picked from commit cdff281f642511ea3d0e077dbe885ec955208a7a)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/train)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/832766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/832765
Committed: https://opendev.org/openstack/neutron/commit/98fe52e15eb7c05ff3337e6235435ffc9e1be4d7
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 98fe52e15eb7c05ff3337e6235435ffc9e1be4d7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 3 02:57:07 2022 +0000

    [SR-IOV] Fix QoS extension to set min/max values

    "ip link" commands allow to define VF rates independently.
    That means, first "rate" (max BW) can be set and in a second
    command "min" (min BW) (check LP bug description).

    However Pyroute2 command to set the VF rates requires to set both.
    If one value is missing ("min_tx_rate", "max_tx_rate"), the library
    sets this value to 0; in other words, the value is deleted.

    The Pyroute2 structures are built depending on the parameter names.
    In this case, {'vf': {'rate': ...}} will create a "vf_rate" [1]
    nla structure, that requires "min_tx_rate" and "max_tx_rate".
    This is part of the full structure passed to the "iproute" library
    [2].

    This is an example of code that only sets the "max_tx_rate" for
    the 15th VF of "enp196s0f0":
      $ from neutron.plugins.ml2.drivers.mech_sriov.agent import pci_lib
        pci = pci_lib.PciDeviceIPWrapper("enp196s0f0")
        pci.set_vf_rate(15, {'max_tx_rate': 10})

    The "msg" [3] (structure passed to "iproute" library) is this:
    https://paste.opendev.org/show/b2FZBOebGOCHMrYhPr6X/. The
    "min_tx_rate" is set to the default value 0.

    This patch reads first the existing rates ("min_tx_rate",
    "max_tx_rate") and populates the command parameters accordingly.

    [1]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/netlink/rtnl/ifinfmsg/__init__.py#L712-L717
    [2]https://github.com/shemminger/iproute2/blob/c8d9d92544668922dc5aa06d2491f42b837b9361/ip/ipaddress.c#L454-L470
    [3]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/iproute/linux.py#L1499

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_eswitch_manager.py

    Closes-Bug: #1962844
    Change-Id: Ibbb6d938355440c42850812e368224b76b1fce19
    (cherry picked from commit cdff281f642511ea3d0e077dbe885ec955208a7a)
    (cherry picked from commit 1cadfc84a5650758153385bb52dea7be713c4184)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/832764
Committed: https://opendev.org/openstack/neutron/commit/42a9b7cafa96f1b10b76d46c556ba031f2cc3275
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 42a9b7cafa96f1b10b76d46c556ba031f2cc3275
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 3 02:57:07 2022 +0000

    [SR-IOV] Fix QoS extension to set min/max values

    "ip link" commands allow to define VF rates independently.
    That means, first "rate" (max BW) can be set and in a second
    command "min" (min BW) (check LP bug description).

    However Pyroute2 command to set the VF rates requires to set both.
    If one value is missing ("min_tx_rate", "max_tx_rate"), the library
    sets this value to 0; in other words, the value is deleted.

    The Pyroute2 structures are built depending on the parameter names.
    In this case, {'vf': {'rate': ...}} will create a "vf_rate" [1]
    nla structure, that requires "min_tx_rate" and "max_tx_rate".
    This is part of the full structure passed to the "iproute" library
    [2].

    This is an example of code that only sets the "max_tx_rate" for
    the 15th VF of "enp196s0f0":
      $ from neutron.plugins.ml2.drivers.mech_sriov.agent import pci_lib
        pci = pci_lib.PciDeviceIPWrapper("enp196s0f0")
        pci.set_vf_rate(15, {'max_tx_rate': 10})

    The "msg" [3] (structure passed to "iproute" library) is this:
    https://paste.opendev.org/show/b2FZBOebGOCHMrYhPr6X/. The
    "min_tx_rate" is set to the default value 0.

    This patch reads first the existing rates ("min_tx_rate",
    "max_tx_rate") and populates the command parameters accordingly.

    [1]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/netlink/rtnl/ifinfmsg/__init__.py#L712-L717
    [2]https://github.com/shemminger/iproute2/blob/c8d9d92544668922dc5aa06d2491f42b837b9361/ip/ipaddress.c#L454-L470
    [3]https://github.com/svinota/pyroute2/blob/a9564dff8e53659f761d71bbee0dd68dd0db6ce8/pyroute2.core/pr2modules/iproute/linux.py#L1499

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_eswitch_manager.py

    Closes-Bug: #1962844
    Change-Id: Ibbb6d938355440c42850812e368224b76b1fce19
    (cherry picked from commit cdff281f642511ea3d0e077dbe885ec955208a7a)
    (cherry picked from commit 1cadfc84a5650758153385bb52dea7be713c4184)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/837092

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/yoga)

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/837107

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/xena)

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/837108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/837109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/victoria)

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/837110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/837111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837092
Committed: https://opendev.org/openstack/neutron/commit/837fda7566fc8d2344d68468be7717563e13008c
Submitter: "Zuul (22348)"
Branch: master

commit 837fda7566fc8d2344d68468be7717563e13008c
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837107
Committed: https://opendev.org/openstack/neutron/commit/480bd3f563cbae7df0b50f1bf2ea5c099b0f3343
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 480bd3f563cbae7df0b50f1bf2ea5c099b0f3343
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837108
Committed: https://opendev.org/openstack/neutron/commit/40c3671339b4ee6fb8e7e8b32c2192adb7b921f9
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 40c3671339b4ee6fb8e7e8b32c2192adb7b921f9
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837109
Committed: https://opendev.org/openstack/neutron/commit/9a94e2855a05aebcda361a5c4cecbfcb106797a6
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9a94e2855a05aebcda361a5c4cecbfcb106797a6
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837110
Committed: https://opendev.org/openstack/neutron/commit/7caeebbbc31a92841a6354a1a20320f31780c51c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 7caeebbbc31a92841a6354a1a20320f31780c51c
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837111
Committed: https://opendev.org/openstack/neutron/commit/13bb2554da87671fa6bfea008039da53d5a07de2
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 13bb2554da87671fa6bfea008039da53d5a07de2
Author: elajkat <email address hidden>
Date: Fri Apr 8 09:29:14 2022 +0200

    Change set_device_rate calls according to new signature

    [1] changed the signature of set_device_rate to be alligned with how
    pyroute2 expects rate parameters, some method which calls
    set_device_rate needs to be changed also to use the new dict format for
    calling it.

    [1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19

    Related-Bug: #1962844
    Closes-Bug: #1968206
    Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
    (cherry picked from commit 837fda7566fc8d2344d68468be7717563e13008c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.4.0

This issue was fixed in the openstack/neutron 17.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.3.0

This issue was fixed in the openstack/neutron 18.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.2.0

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.