Comment 7 for bug 1939726

Hello:

I think there is a problem in the "_sync_metadata_ports" method, in [1]. If the subnet has DHCP disabled, the metadata port should not receive an IP address from this subnet. When a subnet without DHCP is created, the metadata port (already there because is created when the network is), does not receive any IP address.

We should make this check at this point too: if the subnet has "dhcp_enbled" to False, then we should update the port IPs but deleting, if exist, any IP address on this subnet (just the opposite of what is happening now).

Regards.

[1]https://github.com/openstack/neutron/blob/bd7b40b4f871586068039e6014dbb9081d1630e8/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L2230-L2232