@slaweq actually using a template of the config file rather than generating all in code is absolutely something I think we should do because it would make it easier to make changes like this in the future. In terms if which config to change, right now since the ping test is hardcoded in [1] I was thinking of starting my making e.g. number of pings configurable. But now that you mention it perhaps a better approach would be to move the existing code to use a template, the path to which could be configurable so that operators can make their own changes/additions but still have it rendered with the necessary settings (gateway ip etc) by Neutron.
@slaweq actually using a template of the config file rather than generating all in code is absolutely something I think we should do because it would make it easier to make changes like this in the future. In terms if which config to change, right now since the ping test is hardcoded in [1] I was thinking of starting my making e.g. number of pings configurable. But now that you mention it perhaps a better approach would be to move the existing code to use a template, the path to which could be configurable so that operators can make their own changes/additions but still have it rendered with the necessary settings (gateway ip etc) by Neutron.
https:/ /github. com/openstack/ neutron/ blob/114ac0ae89 cfad124a906430b a70c14d0678391a /neutron/ agent/linux/ keepalived. py#L506