commit 45ae9dfb7d5acacc72fcf9f071a9db1beb0ca972
Author: Maciej Józefczyk <email address hidden>
Date: Mon Jan 20 09:39:21 2020 +0000
[OVN] Delete NAT entry first on any FIP update
For now while updating FIP check if port or logical_ip
has changed and only then we deleted the NAT entry.
Unfortunately each time when FIP update occurs the
method _create_or_update_floatingip() is used. It first deletes
LSP pointed by FIP and adds it again along with new NAT entries.
Based on author comment this actions are required.
So if we don't update FIP with logical_ip or new port_id,
like update a description, the NAT entries gets duplicated.
Since all is wrapped withing a transaction and to not wait for
proper fix (this code need sa refactor based on commments with NAT
external_id column) I think thats safe just to delete the NAT entry
in such situation like described above.
Reviewed: https:/ /review. opendev. org/703352 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=45ae9dfb7d5 acacc72fcf9f071 a9db1beb0ca972
Committed: https:/
Submitter: Zuul
Branch: master
commit 45ae9dfb7d5acac c72fcf9f071a9db 1beb0ca972
Author: Maciej Józefczyk <email address hidden>
Date: Mon Jan 20 09:39:21 2020 +0000
[OVN] Delete NAT entry first on any FIP update
For now while updating FIP check if port or logical_ip
has changed and only then we deleted the NAT entry.
Unfortunately each time when FIP update occurs the or_update_ floatingip( ) is used. It first deletes
method _create_
LSP pointed by FIP and adds it again along with new NAT entries.
Based on author comment this actions are required.
So if we don't update FIP with logical_ip or new port_id,
like update a description, the NAT entries gets duplicated.
Since all is wrapped withing a transaction and to not wait for
proper fix (this code need sa refactor based on commments with NAT
external_id column) I think thats safe just to delete the NAT entry
in such situation like described above.
Change-Id: Iea532e2a02b799 2305d1b90aa040e 064901c340c
Related-Bug: #1859977