L2 agent do not clear old QoS rules after restart

Bug #1812576 reported by Chengqian Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Chengqian Liu

Bug Description

This fix is optimized for https://bugs.launchpad.net/neutron/+bug/1810025.
BUG 1810025 only considers the case where the rule is emptied when the agent is stopped, and does not consider the case where the rule is deleted but not emptied when the agent is stopped.

Think about that:
1. Create two different types of rules, such as bandwidth_limit and minimum_bandwidth
2. Stop l2_agent
3. Delete a type of rule, such as bandwidth_limit
4. Start agent
5. Bandwidth_limit still exists

Changed in neutron:
assignee: nobody → Chengqian Liu (liuchengqian90)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/632014

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
summary: - L2 agent do not clear old QoS rules after restart Edit
+ L2 agent do not clear old QoS rules after restart
tags: added: qos
tags: added: pike-backport-potential queens-backport-potential rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/632014
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6f927cc11970b683305c96412d248e63cc15c12b
Submitter: Zuul
Branch: master

commit 6f927cc11970b683305c96412d248e63cc15c12b
Author: liuchengqian90 <xieling1990.happy@163.com>
Date: Wed Jan 30 17:48:59 2019 +0800

    Clear old rules that have been applied before applying new rules.

    To prevent data from being out of sync in the following situations:
    1. Create a policy with two rules bound to the virtual machine
    2. Stop l2-agent
    3. Delete/change/clear policy rule
    4. Start l2-agent (the rule is still there, out-of-sync)

    Change-Id: I194c918d859172c31ae5ce1af925fdbb388f9cfb
    Closes-Bug: #1812576

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b2

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.