L2 agent do not clear QoS rules after restart

Bug #1810025 reported by Chengqian Liu
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Chengqian Liu

Bug Description

I runned a test about qos(driver=openvswitch) based rocky and found the following problems.

1. craete a vm and found its port ,eg port_id= PORT_ID_A .
2. create a policy(eg , id=POLICY_ID) and create bandwidth_limit_rule (max_kbps=50000).
3. update port PORT_ID_A with qos_policy POLICY_ID.
4. 'ovs-vsctl list interface PORT_ID_A' to ensure its correct.

Everything was working fine, so we continue

5. stop neutron-openvswitch-agent
6. delete bandwidth_limit_rule in qos_policy POLICY_ID.
7. start neutron-openvswitch-agent
8. 'ovs-vsctl list interface PORT_ID_A' again ,
   I found 'ingress_policing_rate' and 'ingress_policing_burst' were not changed.
   That was not what I wanted.

Changed in neutron:
assignee: nobody → Chengqian Liu (liuchengqian90)
Changed in neutron:
status: New → In Progress
tags: added: qos
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

Hi Chengqian Liu,

Thx for report this bug. Can You explain what is "CN" in bug title?
Also, I see that You assigned this bug to Your self, are You working on fix for it currently?

Changed in neutron:
importance: Undecided → Medium
Revision history for this message
Chengqian Liu (liuchengqian90) wrote :

Hi Slawek:
CN means "compute node" in bug title and this is the code review:
https://review.openstack.org/#/c/627779/

summary: - CN do not clear QoS rules when ovs-agent restart
+ ovs-agent do not clear QoS rules after restart
Revision history for this message
Slawek Kaplonski (slaweq) wrote : Re: ovs-agent do not clear QoS rules after restart

Ok, thx for explanation and link to patch.
I think that this issue is not related only to neutron-openvswitch-agent but to all L2 agents. Am I right?

Revision history for this message
Chengqian Liu (liuchengqian90) wrote :

Yes.
But I only tested it with openvswitch as the driver.

summary: - ovs-agent do not clear QoS rules after restart
+ L2 agent do not clear QoS rules after restart
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/627779
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=58de79a58bfeda46c6ab7fcaa765b8a557652874
Submitter: Zuul
Branch: master

commit 58de79a58bfeda46c6ab7fcaa765b8a557652874
Author: liuchengqian90 <xieling1990.happy@163.com>
Date: Sat Dec 29 21:39:43 2018 +0800

    Clear residual qos rules after l2-agent restarts.

    During the l2-agent stop, if the policy rule is cleared,
    after the l2-agent is started, the qos rule that has been applied should be cleared.

    Change-Id: Iaaff10dfa8ac6ab8c9dead3124e2bb3caa03a665
    Closes-Bug: #1810025

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/632458

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.openstack.org/632458
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e04ee2c5b66af84f27cc2f1fa0ce3f92fe5676e9
Submitter: Zuul
Branch: stable/rocky

commit e04ee2c5b66af84f27cc2f1fa0ce3f92fe5676e9
Author: liuchengqian90 <xieling1990.happy@163.com>
Date: Sat Dec 29 21:39:43 2018 +0800

    Clear residual qos rules after l2-agent restarts.

    During the l2-agent stop, if the policy rule is cleared,
    after the l2-agent is started, the qos rule that has been applied should be cleared.

    Change-Id: Iaaff10dfa8ac6ab8c9dead3124e2bb3caa03a665
    Closes-Bug: #1810025
    (cherry picked from commit 58de79a58bfeda46c6ab7fcaa765b8a557652874)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/632936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.openstack.org/632936
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=81d51ae876f4b163472de8f24a3ec1d1d7ac2078
Submitter: Zuul
Branch: stable/queens

commit 81d51ae876f4b163472de8f24a3ec1d1d7ac2078
Author: liuchengqian90 <xieling1990.happy@163.com>
Date: Sat Dec 29 21:39:43 2018 +0800

    Clear residual qos rules after l2-agent restarts.

    During the l2-agent stop, if the policy rule is cleared,
    after the l2-agent is started, the qos rule that has been applied should be cleared.

    Change-Id: Iaaff10dfa8ac6ab8c9dead3124e2bb3caa03a665
    Closes-Bug: #1810025
    (cherry picked from commit 58de79a58bfeda46c6ab7fcaa765b8a557652874)
    (cherry picked from commit e04ee2c5b66af84f27cc2f1fa0ce3f92fe5676e9)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b2

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.3

This issue was fixed in the openstack/neutron 13.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.6

This issue was fixed in the openstack/neutron 12.0.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers