Comment 4 for bug 1811506

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/630451
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=f1d40107e86c9febbf439d6ac7195d64d207b081
Submitter: Zuul
Branch: master

commit f1d40107e86c9febbf439d6ac7195d64d207b081
Author: Akihiro Motoki <email address hidden>
Date: Sat Jan 12 20:10:03 2019 +0900

    Define types for C calls in netlink_lib

    Borrowed from neutron fix related to oslo.privsep 1.31
    https://review.openstack.org/#/c/629335/
    -----
    Previously this was not done, which meant all arguments were
    assumed to be ints. As long as we didn't get any large pointer
    addresses this worked fine, but for some reason the addition of
    threading to oslo.privsep triggered larger addresses that were then
    truncated. This caused segfaults in the underlying C library because
    we were passing it invalid pointers.

    This change sets argument and return types for all of the calls
    that are used in the module.
    -----

    Note: The root cause of the failure of
    neutron_fwaas.tests.functional.privileged.InNamespaceTest.test_in_namespace
    is different and it will be covered by the next patch
    (See Ie5b238f1df707ea3ce50b5711ff791bac2681a2f),
    so it is skipped temporarily.

    Partial-Bug: #1811506
    Change-Id: I3ea8c71a96d4c38988a38947c0ebcaf602a57842