commit e83e5618b7ca71fb96bf460922480b9808b431b6
Author: aojeagarcia <email address hidden>
Date: Sun Dec 23 23:43:38 2018 +0100
Don't modify global variables in unit tests
The unit test
test_enable_dhcp_helper_enable_metadata_nonisolated_dist_network
modifies the global variables fake_port1, fake_port2, creating flakiness
on unit tests that use those variables when execured in environments
with high concurrency.
Creating a deepcopy of the variable avoid that those changes can be
propagated to other unit tests.
Reviewed: https:/ /review. openstack. org/627087 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=e83e5618b7c a71fb96bf460922 480b9808b431b6
Committed: https:/
Submitter: Zuul
Branch: master
commit e83e5618b7ca71f b96bf460922480b 9808b431b6
Author: aojeagarcia <email address hidden>
Date: Sun Dec 23 23:43:38 2018 +0100
Don't modify global variables in unit tests
The unit test enable_ dhcp_helper_ enable_ metadata_ nonisolated_ dist_network
test_
modifies the global variables fake_port1, fake_port2, creating flakiness
on unit tests that use those variables when execured in environments
with high concurrency.
Creating a deepcopy of the variable avoid that those changes can be
propagated to other unit tests.
Closes-Bug: #1809643
Change-Id: Idfd0e99739952b af4d7b545b406cd 1b251deb5f8
Signed-off-by: aojeagarcia <email address hidden>