failed to obtain IP from DHCP with infiniband NIC

Bug #1770932 reported by Hamdy Khader
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Hamdy Khader

Bug Description

DHCP option used to be 'client-id' and that causes issues with infiniband.
For infiniband we need to add 'client-id' DHCP option to get IP address, neutron change 'client-id' to number 61 to meet rfc4776.

change:
https://github.com/openstack/ironic/commit/228a2a7885e1b04d4180fe8daa2992884decaf6d

rfc4776:
https://tools.ietf.org/html/rfc4776

Changed in neutron:
assignee: nobody → Hamdy Khader (hamdyk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/567583
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59bc19c14a84283adad555dce8536fd7198b82b3
Submitter: Zuul
Branch: master

commit 59bc19c14a84283adad555dce8536fd7198b82b3
Author: Hamdy Khader <email address hidden>
Date: Thu May 10 15:58:42 2018 +0300

    Use Param DHCP_OPT_CLIENT_ID_NUM

    Ironic is sending 'client-id' as a number (61) to meet rfc4776 [1],
    due to this change Neutron DHCP should support this option as well.

    [1] https://github.com/openstack/ironic/commit/228a2a7885e1b04d4180fe8daa2992884decaf6d

    Closes-Bug: #1770932
    Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/569573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/569575

Revision history for this message
Brian Haley (brian-haley) wrote :

Can you help me understand the importance of this in regards to backports? Are you running into this problem on Pike and things are unusable?

Revision history for this message
Hamdy Khader (hamdyk) wrote :

We only had this issue after this change:
https://github.com/openstack/ironic/commit/228a2a7885e1b04d4180fe8daa2992884decaf6d

since it is present in branches "stable/queens" and was backported to "stable/pike" (https://github.com/openstack/ironic/commit/78c4d016461bf88030e4e304b912bd7a1f711815)

we need to do the same fix master (done) and backport to queens and pike.

Revision history for this message
Brian Haley (brian-haley) wrote :

Ok, thanks. So I will set this to High based on the Ironic bug that broke (fixed?) things, https://bugs.launchpad.net/ironic/+bug/1717236

Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/569575
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e8c4eb00c2eba8b4f33624ee4ce71d41738573c5
Submitter: Zuul
Branch: stable/pike

commit e8c4eb00c2eba8b4f33624ee4ce71d41738573c5
Author: Hamdy Khader <email address hidden>
Date: Thu May 10 15:58:42 2018 +0300

    Use Param DHCP_OPT_CLIENT_ID_NUM

    Ironic is sending 'client-id' as a number (61) to meet rfc4776 [1],
    due to this change Neutron DHCP should support this option as well.

    [1] https://github.com/openstack/ironic/commit/228a2a7885e1b04d4180fe8daa2992884decaf6d

    Closes-Bug: #1770932
    Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737
    (cherry picked from commit 59bc19c14a84283adad555dce8536fd7198b82b3)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.openstack.org/569573
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf8478e340b89f0f6652a71fdfae21ca8f36f6fc
Submitter: Zuul
Branch: stable/queens

commit cf8478e340b89f0f6652a71fdfae21ca8f36f6fc
Author: Hamdy Khader <email address hidden>
Date: Thu May 10 15:58:42 2018 +0300

    Use Param DHCP_OPT_CLIENT_ID_NUM

    Ironic is sending 'client-id' as a number (61) to meet rfc4776 [1],
    due to this change Neutron DHCP should support this option as well.

    [1] https://github.com/openstack/ironic/commit/228a2a7885e1b04d4180fe8daa2992884decaf6d

    Closes-Bug: #1770932
    Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737
    (cherry picked from commit 59bc19c14a84283adad555dce8536fd7198b82b3)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/567582
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=a948801e2ca4bf2d6fdeafa94fe65e60ec0d4f77
Submitter: Zuul
Branch: master

commit a948801e2ca4bf2d6fdeafa94fe65e60ec0d4f77
Author: Hamdy Khader <email address hidden>
Date: Thu May 10 15:57:09 2018 +0300

    Add DHCP_OPT_CLIENT_ID_NUM

    For Infiniband support, Ironic needs to send the 'client-id' DHCP option
    as a number in order for IP address assignment to work.
    This is now supported in Neutron, and can be specified as option number
    61 as defined in RFC 4776.

    Partial-Bug: #1770932
    Change-Id: Id8272ecfac41670693482f11d6bcb6ad211b993f

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.0.0b2

This issue was fixed in the openstack/neutron 13.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.3

This issue was fixed in the openstack/neutron 12.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.5

This issue was fixed in the openstack/neutron 11.0.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers