PXE options are not understood correctly by some Neutron backends due to theirs names

[Vasyl Saienko]

Different Neutron backeds (dhcp servers) may use different option names. A good example is dnsmasq and contrail. To avoid this we need to set options by theirs values instead of names as value is a standard defined by IANA

https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml

[Vasyl Saienko (vsaienko)]

fix: https://review.openstack.org/#/c/499553/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499553
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c377f5cbbd034e16b68a3fc30e138b03badc9c94
Submitter: Jenkins
Branch: master

commit c377f5cbbd034e16b68a3fc30e138b03badc9c94
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:55:33 2017 +0300

    Change pxe dhcp options name to codes.

    There is difference between dhcp option names in different backends.
    This patch changes options name to code according to [0].

    [0] https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml

    Closes-Bug: 1717236

    Change-Id: Idbc2f7496d10d92d8dc481eb4173ed1c6f35d412

[Ruby Loo (rloo)]

https://review.openstack.org/499553 was reverted in https://review.openstack.org/#/c/505797/.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/506173
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=228a2a7885e1b04d4180fe8daa2992884decaf6d
Submitter: Zuul
Branch: master

commit 228a2a7885e1b04d4180fe8daa2992884decaf6d
Author: Vasyl Saienko <email address hidden>
Date: Thu Sep 21 13:39:28 2017 +0000

    Change pxe dhcp options name to codes.

    There is difference between dhcp option names in different backends.
    This patch changes options name to code according to [0].

    [0] https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml

    Closes-Bug: 1717236

    This is an updated version of c377f5cbbd034e16b68a3fc30e138b03badc9c94
    which problems with PXE and dnsmasq due to buggy dnsmasq code which uses
    siaddr field to specify tftp server. They are addressed now by always
    sending server-ip-address to make sure that dnsmasq works.

    More information about siaddr and option 150,66 can be found in
    informational RFC https://tools.ietf.org/html/rfc5859

    Change-Id: I55487d867979bf6bb4cf228fcf6408beae955d2b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/525248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/525248
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=78c4d016461bf88030e4e304b912bd7a1f711815
Submitter: Zuul
Branch: stable/pike

commit 78c4d016461bf88030e4e304b912bd7a1f711815
Author: Vasyl Saienko <email address hidden>
Date: Thu Sep 21 13:39:28 2017 +0000

    Change pxe dhcp options name to codes.

    There is difference between dhcp option names in different backends.
    This patch changes options name to code according to [0].

    [0] https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml

    Closes-Bug: 1717236

    This is an updated version of c377f5cbbd034e16b68a3fc30e138b03badc9c94
    which problems with PXE and dnsmasq due to buggy dnsmasq code which uses
    siaddr field to specify tftp server. They are addressed now by always
    sending server-ip-address to make sure that dnsmasq works.

    More information about siaddr and option 150,66 can be found in
    informational RFC https://tools.ietf.org/html/rfc5859

    Change-Id: I55487d867979bf6bb4cf228fcf6408beae955d2b
    (cherry picked from commit 228a2a7885e1b04d4180fe8daa2992884decaf6d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.1.5 release.