After an upgrade we can get NotFound exceptions from AMQP after there
are no longer any agents interested in listening to that exchange.
These should be ignored and not propagated up since they don't indicate
any kind of issue.
However, oslo messaging is not translating the exceptions into an
oslo.messaging exception so there is no way to catch them without
importing amqp directly.
As a workround to unblock Ironic, this patch just proposes a generic
catch of all exceptions during a cast. These casts occur after work
has been done so raising them back to the user doesn't do anything
useful anyway.
Once we have an oslo.messaging exception to catch we can narrow it to
that.
Reviewed: https:/ /review. openstack. org/485365 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=93d45fe1ab8 96c1ec9d183d9ab 3c4248cf0aa5ea
Committed: https:/
Submitter: Jenkins
Branch: master
commit 93d45fe1ab896c1 ec9d183d9ab3c42 48cf0aa5ea
Author: Kevin Benton <email address hidden>
Date: Wed Jul 19 15:00:06 2017 -0700
Ignore cast exceptions in AgentNotifierApi
After an upgrade we can get NotFound exceptions from AMQP after there
are no longer any agents interested in listening to that exchange.
These should be ignored and not propagated up since they don't indicate
any kind of issue.
However, oslo messaging is not translating the exceptions into an
oslo.messaging exception so there is no way to catch them without
importing amqp directly.
As a workround to unblock Ironic, this patch just proposes a generic
catch of all exceptions during a cast. These casts occur after work
has been done so raising them back to the user doesn't do anything
useful anyway.
Once we have an oslo.messaging exception to catch we can narrow it to
that.
Change-Id: I15cc2d6ae48e50 5c2da121880e274 81dedf36d3b
Partial-Bug: #1705351