commit ff3132d8d455012b2b29f1eb65817f8492f84fe9
Author: Kevin Benton <email address hidden>
Date: Fri Mar 3 10:57:57 2017 -0800
Stop killing conntrack state without CT Zone
The conntrack clearing code was belligerenty killing connections
without a conntrack zone specifier when it couldn't get the zone
for a given device. This means it would kill all connections based
on an IP address match, which meant hitting innocent bystanders
in other tenant networks with overlapping IP addresses.
This bad fallback was being triggered every time because it was
using the wrong identifier for a port to look up the zone.
This patch fixes the port lookup and adjusts the fallback behavior
to never clear conntrack entries if we can't find the conntrack
zone for a port.
This triggered the bug below (in the cases I root-caused) by
killing a metadata connection right in the middle of retrieving
a key.
Reviewed: https:/ /review. openstack. org/441346 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=ff3132d8d45 5012b2b29f1eb65 817f8492f84fe9
Committed: https:/
Submitter: Jenkins
Branch: master
commit ff3132d8d455012 b2b29f1eb65817f 8492f84fe9
Author: Kevin Benton <email address hidden>
Date: Fri Mar 3 10:57:57 2017 -0800
Stop killing conntrack state without CT Zone
The conntrack clearing code was belligerenty killing connections
without a conntrack zone specifier when it couldn't get the zone
for a given device. This means it would kill all connections based
on an IP address match, which meant hitting innocent bystanders
in other tenant networks with overlapping IP addresses.
This bad fallback was being triggered every time because it was
using the wrong identifier for a port to look up the zone.
This patch fixes the port lookup and adjusts the fallback behavior
to never clear conntrack entries if we can't find the conntrack
zone for a port.
This triggered the bug below (in the cases I root-caused) by
killing a metadata connection right in the middle of retrieving
a key.
Closes-Bug: #1668958 958ac927980d801 19c53ea519b
Change-Id: Ia4ee9b3305e89c