Forbid importing neutron.tests.* from outside tests subtree
neutron-sanity-check tool was importing neutron.tests.base module, which
may be not present on some systems (f.e. RDO splits neutron/tests/
subtree in a separate python-neutron-tests package). It made the tool
not usable in some setups.
This is not the first time when we by mistake import from
neutron.tests.* and break distributions. It's time to stop it by
proactively forbidding that pattern via a new hacking check.
Some functions were moved from neutron.tests.base to
neutron.common.utils to fulfill the need requirement. They were moved
using debtcollector, no current consumers should be affected.
Reviewed: https:/ /review. openstack. org/367340 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=31e1aeb66b2 d8abb0d8424e955 0693fad6f37c1c
Committed: https:/
Submitter: Jenkins
Branch: master
commit 31e1aeb66b2d8ab b0d8424e9550693 fad6f37c1c
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Aug 30 10:42:41 2016 +0000
Forbid importing neutron.tests.* from outside tests subtree
neutron- sanity- check tool was importing neutron.tests.base module, which neutron- tests package). It made the tool
may be not present on some systems (f.e. RDO splits neutron/tests/
subtree in a separate python-
not usable in some setups.
https:/ /bugzilla. redhat. com/show_ bug.cgi? id=1374282
This is not the first time when we by mistake import from
neutron.tests.* and break distributions. It's time to stop it by
proactively forbidding that pattern via a new hacking check.
Some functions were moved from neutron.tests.base to common. utils to fulfill the need requirement. They were moved
neutron.
using debtcollector, no current consumers should be affected.
Closes-Bug: #1621782 2218b3db54ae3d5 c931d72d4fa
Change-Id: I790777ddcbd1b0