Comment 7 for bug 1597898

Reviewed: https://review.openstack.org/348558
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c6b30c392f4bd778e1b69fe1a1b82c9832b83e29
Submitter: Jenkins
Branch: master

commit c6b30c392f4bd778e1b69fe1a1b82c9832b83e29
Author: Richard Theis <email address hidden>
Date: Thu Jun 30 16:17:28 2016 -0500

    Fix L3 NAT DB signature mismatch

    Agentless L3 plugins, such as used by networking-ovn, are required
    to inherit from L3_NAT_db_mixin instead of L3_NAT_dbonly_mixin.
    One reason is that the do_notify=False argument is passed to the
    L3 plugin's disassociate_floatingips() method by the ML2 plugin
    during delete_port(). However, the argument doesn't exist in the
    parent class method. This patch fixes the signature mismatch.

    In addition, agentless L3 plugins implicitly pick up callbacks
    intended for use by L3 agents. Such callbacks will fail unless
    the L3 plugin inherits from L3_NAT_db_mixin. This will be fixed
    in a separate patch.

    The result is that agentless L3 plugins will have added RPC
    notification overhead which isn't necessary.

    Change-Id: I7a7e6b8f07974ac877d36ccb0a94100bf0e07a0e
    Partial-Bug: #1597898