Comment 8 for bug 1575247

Revision history for this message
Carl Baldwin (carl-baldwin) wrote : Re: network query when creating subnet looks too complex

Could we express this bug in terms of factors that really matter from an external point of view?

I don't think that the complexity of the query is what we should state as the bug. I think we need to rephrase the bug in a way that tells how the performance of the code is not meeting some reasonable expectation. First, start with what use case is being run. What is the observed performance? What was expected? What is acceptable?

The complexity of the query might the underlying problem but I'd like to see the process that led to that conclusion. Yesterday, I approved the revert of an optimization that was added because someone looked under the hood, thought some code would perform better if written another way, and proposed a change that didn't affect performance in any significant way but introduced a regression. I want to make sure that we're focused on real problems and not fixing things that look bad to us but don't make any real difference in the big picture.