Comment 4 for bug 1551958

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/286920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d1c501cd1d31ed3f859975b40c01cb7aaa06d26d
Submitter: Jenkins
Branch: master

commit d1c501cd1d31ed3f859975b40c01cb7aaa06d26d
Author: Kevin Benton <email address hidden>
Date: Tue Mar 1 13:49:48 2016 -0800

    L3HA: Do not wrap create/delete in transaction

    This is unsafe when calling ML2 because ML2 assumes that its
    functions will not be called inside of a transaction. This is
    not only an issue for drivers that try to do DB lookups using
    a different session in the post commit operation, but it's a
    big issue for the delete methods.

    The delete subnet and network methods in ML2 have 'while True'
    loops that catch concurrency errors and retry the operation after
    looking up info. If these are called inside a transaction, the
    lookups will contain stale information and it can lead to the
    while True loop never terminating!

    Closes-Bug: #1551958
    Change-Id: I33dc084ed15e5491fdda19da712a746ca87fbc8c