Comment 5 for bug 1551530

Reviewed: https://review.openstack.org/298884
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3507c097e8b27333a5d583b915149e5b20e70fb6
Submitter: Jenkins
Branch: stable/liberty

commit 3507c097e8b27333a5d583b915149e5b20e70fb6
Author: Hong Hui Xiao <email address hidden>
Date: Tue Mar 1 05:42:42 2016 +0000

    Add fip nat rules even if router disables shared snat

    For legacy router, there are some iptables rules added for external gateway
    port. Some of these rules are for shared snat, some are for floating ip.

    When user disables shared snat of router gateway, some of the iptables rules
    that floating ip needs will not be added to router. This will cause the
    reported bug, ping floating ip but reply with fixed ip.

    The fix will add the iptables rules that floating ip needs, no matter if
    router enables shared snat. A functional test is also added for the issue.

    Conflicts:
     neutron/agent/l3/router_info.py
     neutron/tests/unit/agent/l3/test_agent.py

    Change-Id: I3cf4dff90f47a720a2e6a92c9ede2bc067ebd6e7
    Closes-Bug: #1551530
    (cherry picked from commit cea149212e6387932eaac8448c951d2ceb7ae23d)