commit 8dcf39aae7a099e01bd322891526c134e87e6b1b
Author: Kevin Benton <email address hidden>
Date: Wed Jan 27 02:17:01 2016 -0800
Unmarshall portinfo on update_fdb_entries calls
The unmarshalling function was not aware of the data
structure used by update_fdb_entries, so it would not
setup PortInfo named tuples in the 'before' and 'after'
fields. This would break the fdb_chg_ip_tun function
which expected to be able to use named attributes.
This patch adjusts the unmarshalling function to be aware
of this datastrucure.
This has likely been broken since the change that added
named tuples here: I7f8c93b0e12ee0179bb23dfbb3a3d814615b1c2e
It probably went undetected for so long because the exception
will only be observed when the updated entry does not have
an agent IP that matches the local agent's (i.e. not single-node).
Even in a multi-node environment, this would only trigger an
error when the fixed_ips of a port changed so it wouldn't show
up in a normal port wiring life-cycle.
Reviewed: https:/ /review. openstack. org/272986 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=8dcf39aae7a 099e01bd3228915 26c134e87e6b1b
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8dcf39aae7a099e 01bd322891526c1 34e87e6b1b
Author: Kevin Benton <email address hidden>
Date: Wed Jan 27 02:17:01 2016 -0800
Unmarshall portinfo on update_fdb_entries calls
The unmarshalling function was not aware of the data
structure used by update_fdb_entries, so it would not
setup PortInfo named tuples in the 'before' and 'after'
fields. This would break the fdb_chg_ip_tun function
which expected to be able to use named attributes.
This patch adjusts the unmarshalling function to be aware
of this datastrucure.
This has likely been broken since the change that added 179bb23dfbb3a3d 814615b1c2e
named tuples here: I7f8c93b0e12ee0
It probably went undetected for so long because the exception
will only be observed when the updated entry does not have
an agent IP that matches the local agent's (i.e. not single-node).
Even in a multi-node environment, this would only trigger an
error when the fixed_ips of a port changed so it wouldn't show
up in a normal port wiring life-cycle.
Closes-Bug: #1538387 0ebfb801f77b186 075303c3df5
Change-Id: I0aacb3af9ebd16